Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MiMa filters #21379

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Fix MiMa filters #21379

merged 2 commits into from
Aug 13, 2024

Conversation

hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented Aug 13, 2024 •
edited
Loading

@Kordyjan
Copy link
Contributor

Is it some problem that it is solving?

@hamzaremmal
Copy link
Member Author

Yes, I just linked the comment

@hamzaremmal
Copy link
Member Author

I'm adding a second commit with all the missing filters right now...

@Kordyjan
Copy link
Contributor

Kordyjan commented Aug 13, 2024 •
edited
Loading

Ok, that makes sense then as a fix.

Edit: I was speaking about the regex part. About the filters, we will see after the CI.

@hamzaremmal
Copy link
Member Author

Some additional information about the issue here: #21374 (comment)

@hamzaremmal hamzaremmal marked this pull request as ready for review August 13, 2024 14:39
@hamzaremmal hamzaremmal enabled auto-merge August 13, 2024 14:41
@hamzaremmal hamzaremmal merged commit f1adc55 into scala:main Aug 13, 2024
25 checks passed
@hamzaremmal hamzaremmal deleted the fix-mima branch August 13, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kordyjan Kordyjan Kordyjan approved these changes

@WojciechMazur WojciechMazur Awaiting requested review from WojciechMazur

Assignees

@Kordyjan Kordyjan

@WojciechMazur WojciechMazur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamzaremmal @Kordyjan @WojciechMazur