[3.5.1] Revert "Heal member-select on opaque reference" #21340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4443395.
This was referenced Aug 7, 2024
WojciechMazur
approved these changes
Aug 8, 2024
WojciechMazur
added a commit
that referenced
this pull request
Aug 8, 2024
This reverts commit 4443395. This reverts the behaviour changing part of #19730, which could make code that previously compiled, continue to compile but with a different runtime behaviour. Now, the code in question is very niche and esoteric, and effectively exploiting this opaque typing bug. So, we're happy to change the compiler to make this behaviour silently change, just not in a patch release. (Same as #21340, but for the LTS.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4443395.
This reverts the behaviour changing part of #19730, which could make code that previously compiled, continue to
compile but with a different runtime behaviour. Now, the code in question is very niche and esoteric, and
effectively exploiting this opaque typing bug. So, we're happy to change the compiler to make this behaviour
silently change, just not in a patch release.