Bump scala-cli to 1.4.1 + drop old cli management #21234
Conversation
hamzaremmal
added
the
backport:nominated
|
BTW we'll likely want it backported to 3.5.1 because of VirtusLab/scala-cli#3029 |
hamzaremmal
force-pushed
the
bump-scala-cli
branch
from
4d12fd7 to
7695d9b
Compare
| else | ||
| SCALA_CLI_CMD_BASH=("\"$PROG_HOME/bin/scala-cli\"") | ||
| fi | ||
| SCALA_CLI_CMD_BASH=("\"$PROG_HOME/bin/scala-cli\"") |
There was a problem hiding this comment.
I wonder do we really need this cli-common-platform files anymore. There seems to be exactly 1 usage for each of them
There was a problem hiding this comment.
We need to keep these 2 files separated because we have different content depending on what we are building. If we build universal archives (with jars and no native binaries), we will be using https://github.com/scala/scala3/blob/d48ba033d8128e04727dbee88a5a8eb3fa98d26d/dist/bin/cli-common-platform and https://github.com/scala/scala3/blob/main/dist/bin/cli-common-platform.bat. While if we are building archives with native binaries, we will be using https://github.com/scala/scala3/d48ba033d8128e04727dbee88a5a8eb3fa98d26d/main/dist/bin-native-overrides/cli-common-platform and https://github.com/scala/scala3/blob/d48ba033d8128e04727dbee88a5a8eb3fa98d26d/dist/bin-native-overrides/cli-common-platform.bat
|
I will wait for @bishabosha's review before merging this. unless we have some time constraints for backporting (@WojciechMazur ?) |
There won't be a 3.5.1-RC2 before 3.5.0 is published, so don't worry about the backports |
WojciechMazur
added
backport:accepted
WojciechMazur
added
backport:done
cc @WojciechMazur @Kordyjan