Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't use color codes for pattern match code action #21120

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix: don't use color codes for pattern match code action #21120

merged 1 commit into from
Jul 11, 2024

Conversation

kasiaMarek
Copy link
Contributor

dwijnand
dwijnand reviewed Jul 8, 2024
View reviewed changes
compiler/src/dotty/tools/dotc/reporting/messages.scala Outdated
extends Message(PatternMatchExhaustivityID) {
def kind = MessageKind.PatternMatchExhaustivity

private val hasMore = uncoveredCases.lengthCompare(6) > 0
val uncovered = uncoveredCases.take(6).mkString(", ")
val uncovered = uncoveredCases.take(6).map(SpaceEngine.display(_)).mkString(", ")
private val casesWithoutColor = uncoveredCases.map(SpaceEngine.display(_, withoutColors = true))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap this call to display with ctx.withoutColors instead of the withoutColors param

@kasiaMarek kasiaMarek marked this pull request as ready for review July 10, 2024 11:47
tgodzik
tgodzik approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Anyone against merging it in the current state?

@dwijnand dwijnand merged commit 25ad99c into scala:main Jul 11, 2024
24 checks passed
@kasiaMarek kasiaMarek mentioned this pull request Jul 11, 2024
Closed
@WojciechMazur WojciechMazur mentioned this pull request Aug 27, 2024
Merged
WojciechMazur added a commit that referenced this pull request Aug 27, 2024
@WojciechMazur
Backport "fix: don't use color codes for pattern match code action" t…
93e3da0 
…o 3.5.2 (#21450)

Backports #21120 to the 3.5.2 branch.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur added this to the 3.5.2 milestone Oct 8, 2024
@prolativ prolativ mentioned this pull request Nov 20, 2024
Merged
WojciechMazur added a commit that referenced this pull request Dec 2, 2024
@WojciechMazur
Backport "fix: don't use color codes for pattern match code action" t…
7766fe9 
…o LTS (#21991)

Backports #21120 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand left review comments

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.2
Development

Successfully merging this pull request may close these issues.

Bug: Insert Missing Cases For Type Union
4 participants
@kasiaMarek @dwijnand @tgodzik @WojciechMazur