Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump scala-cli to 1.4.0 #20859

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Bump scala-cli to 1.4.0 #20859

merged 1 commit into from
Jul 1, 2024

Conversation

hamzaremmal
Copy link
Member

No description provided.

hamzaremmal
hamzaremmal commented Jun 28, 2024
View reviewed changes
project/Build.scala
/** Version of Scala CLI to download (on Windows - last known validated version) */
val scalaCliLauncherVersionWindows = "1.3.2"
val scalaCliLauncherVersionWindows = "1.4.0"
Copy link
Member Author

@hamzaremmal hamzaremmal Jun 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is brand new, we should come up with the procedure when updating scala-cli. 1.4.0 was just released yesterday and is not validated by windows... but it is a change in minor and it is weird to have different scala-cli versions for the same scala release...

Copy link
Member

@bishabosha bishabosha Jun 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point of this windows cli version is that we don't update it, the real Scala-cli version is passed as a command line flag

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know but it weird to have different minor versions across different platforms for the same release of scala

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, we should keep it until 1.4.0 is at least 30 days old.
However, might still be tempting to get this in to have the fix from VirtusLab/scala-cli#2957...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but the decision was made

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I know.
Let's hold our horses until we decide on a timeline for this.

@Gedochao Gedochao added needs-minor-release This PR cannot be merged until the next minor release backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Jun 28, 2024
@Gedochao
Copy link
Contributor

Gedochao commented Jul 1, 2024

While bumping Scala CLI v1.4.0, we might want to pass the --skip-cli-updates launcher option in the scala script on platforms other than Windows (more detail on it in VirtusLab/scala-cli#2957)
It wouldn't be necessary on Windows, since --skip-cli-updates is passed implicitly when --cli-version is used.

@hamzaremmal hamzaremmal mentioned this pull request Jul 1, 2024
Merged
@hamzaremmal hamzaremmal merged commit b018397 into scala:main Jul 1, 2024
24 checks passed
@hamzaremmal hamzaremmal deleted the bump-scala-cli branch July 1, 2024 09:55
hamzaremmal added a commit that referenced this pull request Jul 1, 2024
@hamzaremmal
Add --skip-cli-updates by default to the scala command (#20900)
771d1db 
Based on #20859

Solve #20859 (comment)
@WojciechMazur WojciechMazur added this to the 3.5.0 milestone Jul 1, 2024
WojciechMazur pushed a commit to WojciechMazur/dotty that referenced this pull request Jul 1, 2024
@hamzaremmal @WojciechMazur
Bump scala-cli to 1.4.0 (scala#20859)
e74d681
@WojciechMazur WojciechMazur mentioned this pull request Jul 1, 2024
Merged
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Jul 1, 2024
WojciechMazur added a commit that referenced this pull request Jul 2, 2024
@WojciechMazur
Backport "Bump scala-cli to 1.4.0" to 3.5.0 (#20909)
c48b224 
Backports #20859 to Scala 3.5.0-RC3
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao approved these changes

@bishabosha bishabosha bishabosha approved these changes

Assignees

@bishabosha bishabosha

@Gedochao Gedochao

Labels
backport:done This PR was successfully backported. needs-minor-release This PR cannot be merged until the next minor release
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hamzaremmal @Gedochao @bishabosha @WojciechMazur