Adapt the workflow to release on SDKMAN! #20535
Conversation
hamzaremmal
force-pushed
the
sdkman-workflow
branch
3 times, most recently
from
eae8194 to
aa9d461
Compare
hamzaremmal
force-pushed
the
sdkman-workflow
branch
from
aa9d461 to
857bf12
Compare
hamzaremmal
added
the
backport:nominated
.github/workflows/publish-sdkman.yml
Outdated
| runs-on: ubuntu-latest | ||
| needs: publish | ||
| steps: | ||
| - uses: hamzaremmal/sdkman-default-action@main # TODO: Make a release of the action and configure the version here |
There was a problem hiding this comment.
Do you have any estimate of how much effort would take to make a release for these actions? I'm mostly sceptical about using a main branch directly as it's fragile to any changes.
A tag (preferred if possible) or even a commit pointing to well known revision might be a better idea and might prevent getting any unexpected changes in these workflows when publishing.
There was a problem hiding this comment.
Not much actually, I just have to write the documentation for it and ask the author of sdkman about the body of the reponse to parse it to extract them as outputs. (See action.yml). In all cases, this action is fully working but I don't have the time at the moment to polish these details.
A tag (preferred if possible) or even a commit pointing to well known revision might be a better idea and might prevent getting any unexpected changes in these workflows when publishing.
Agreed, I will update these to use the commit instead of the branch.
WojciechMazur
added
backport:accepted
WojciechMazur
added
backport:done
Adapts the workflow to the changes in #20351