Add support for Chocolatey #20534
Add support for Chocolatey #20534
Conversation
hamzaremmal
force-pushed
the
chocolatey-config
branch
2 times, most recently
from
133391d to
0934b95
Compare
| <projectUrl>https://scala-lang.org/</projectUrl> | ||
| <bugTrackerUrl>https://github.com/scala/scala3/issues</bugTrackerUrl> | ||
| <copyright>© 2002-2024, LAMP/EPFL</copyright> | ||
| <iconUrl>https://cdn.jsdelivr.net/gh/scala/scala3@version/pkgs/chocolatey/icon.svg</iconUrl> |
There was a problem hiding this comment.
I will have to add the hash of the merge-commit after we merge it here
| <iconUrl>https://cdn.jsdelivr.net/gh/scala/scala3@version/pkgs/chocolatey/icon.svg</iconUrl> | |
| <iconUrl>https://cdn.jsdelivr.net/gh/scala/scala3@<merge-commit>/pkgs/chocolatey/icon.svg</iconUrl> |
hamzaremmal
force-pushed
the
chocolatey-config
branch
from
1f23b0b to
45d5f88
Compare
hamzaremmal
force-pushed
the
chocolatey-config
branch
16 times, most recently
from
d3e7d75 to
0c1048a
Compare
hamzaremmal
force-pushed
the
chocolatey-config
branch
from
0c1048a to
333bc98
Compare
hamzaremmal
force-pushed
the
chocolatey-config
branch
from
333bc98 to
b67e186
Compare
hamzaremmal
force-pushed
the
chocolatey-config
branch
from
4d92643 to
5af4908
Compare
Co-authored-by: Jamie Thompson <[email protected]>
| - name: Compute SHA256 of the uploaded artifact (win x86-64) | ||
| id : win-x86_64-digest | ||
| run : | | ||
| curl -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" -o artifact.zip -L https://api.github.com/repos/scala/scala3/actions/artifacts/${{ steps.win-x86_64.outputs.artifact-id }}/zip | ||
| echo "digest=$(sha256sum artifact.zip | cut -d " " -f 1)" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
I just want to ping that there is an issue about this : actions/upload-artifact#454
| version: ${{ inputs.version }} | ||
| secrets: | ||
| API-KEY: ${{ secrets.CHOCOLATEY_KEY }} | ||
|
|
There was a problem hiding this comment.
There is a beneath that line, sees to be outdated now
# TODO: ADD RELEASE WORKFLOW TO CHOCOLATEY AND OTHER PACKAGE MANAGERS HERE
There was a problem hiding this comment.
Right, the chocolatey word should be dropped
| uses: ./.github/workflows/build-chocolatey.yml | ||
| needs: [ build-sdk-package ] | ||
| with: | ||
| version: 3.6.0-local # TODO: FIX THIS |
There was a problem hiding this comment.
Shouldn't this be fixed before the merge? There is another usage of that in the next job.
I guess this value would need to be frequently updated, so it should be documented somewhere (maybe a mention in the project/Build.scala baseVersion that changing one value should also update ci file)
There was a problem hiding this comment.
Maybe build-chocolatey.yml can expose version as output. That way we would never forget about synchronizing the versions in both of the jobs
There was a problem hiding this comment.
actually, this value when testing doesn't matter. I just have to give a version number to the package we are currently building (this package is local to the build). Nevertheless, it would be great if we have something that is correct and computes it directly without doing anything else.
There was a problem hiding this comment.
I've added a todo to check later what to change this value to but it is not at all a blocker
[test_chocolatey] Resolves #20534 (comment)
|
@hamzaremmal Should this PR be backported to LTS 3.3.5? |
|
@prolativ Would be good to have it yes. If the backport is hard to do, I can open a PR that targets LTS 3.3x |
|
@hamzaremmal How should I adapt the backport for LTS? |
|
At this point direct backport is not possible - we'd need to adjust it to pre-3.5 building of artifacts. It's assuming usage of universal packager. Also Scala 3.3 LTS also would not have a native runners. |
Backports #20534 and #21221 to LTS. Requires adaptation - we don't produce native launchers and don't use universal packager plugin [test_chocolatey] --------- Co-authored-by: Hamza Remmal <[email protected]>
Closes #20380
TODO:
[x] Generatemsifiles forscala(issue: Publish platform-native launchers for Scala CLI as thescalarunner command #20378) (Will be done in another PR, but we should already know the format of the URL)publish-chocolatey.yml)logo.ico) file[test_chocolatey]