Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup retains annotations in all inferred type trees #20305

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Linyxus
Copy link
Contributor

@Linyxus Linyxus commented Apr 30, 2024

fixes #20272

@mbovel
Copy link
Member

mbovel commented May 1, 2024

For information, both the first test case passes in #19957, which I hope to get merged soonish.

@Linyxus
Copy link
Contributor Author

Linyxus commented May 1, 2024

For information, both test cases pass in #19957, which I hope to get merged soonish.

Could #19957 supersede this one?

@mbovel
Copy link
Member

mbovel commented May 6, 2024

Could #19957 supersede this one?

I was hopping that correctly mapping annotations from the start could help, but I don't know if it could completely avoid the need for cleanupRetainsAnnot.

@mbovel
Copy link
Member

mbovel commented Nov 21, 2024

I was wondering: what is the status of this PR? Did you not need it in the end?

I was also wondering: have you considered cleaning up these annotations earlier in widenInferred or such instead of doing it in PostTyper?

@Linyxus
Copy link
Contributor Author

Linyxus commented Nov 23, 2024

I cannot really remember why we did not need it in the end to capture-check the stdlib. I could check the status.

Regarding widenInferred, I was not aware of this method before, and it might be worth a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orphan type parameter references crash pickler in capture checked programs
2 participants