Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Java 17 in the CI #19703

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Switch to Java 17 in the CI #19703

merged 1 commit into from
Feb 16, 2024

Conversation

hamzaremmal
Copy link
Member

This will unblock #19080.

Support for Java 21 will be provided by #19701 later

@hamzaremmal hamzaremmal self-assigned this Feb 15, 2024
@hamzaremmal hamzaremmal marked this pull request as ready for review February 15, 2024 22:29
@hamzaremmal hamzaremmal requested a review from smarter February 15, 2024 22:29
smarter
smarter requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@smarter smarter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the CI logs there is:

[info] welcome to sbt 1.9.7 (Private Build Java 1.8.0_282)

So this is actually running on Java 8, because Java 17 isn't installed in the docker image and so /usr/lib/jvm/java-17/openjdk-amd64/bin doesn't exist and the java executable defaults to a java 8 installation on the PATH.

@hamzaremmal
Copy link
Member Author

In the CI logs there is:

[info] welcome to sbt 1.9.7 (Private Build Java 1.8.0_282)

So this is actually running on Java 8, because Java 17 isn't installed in the docker image and so /usr/lib/jvm/java-17/openjdk-amd64/bin doesn't exist and the java executable defaults to a java 8 installation on the PATH.

Java 17 should be installed too 🤔 (along side Java 8 and Java 21) : https://github.com/lampepfl/dotty-ci/blob/1df1746e8cf5077b7e2b87906ee3dda3b908fb20/dotty-docker/Dockerfile#L13

@hamzaremmal
Copy link
Member Author

hamzaremmal commented Feb 15, 2024 •
edited
Loading

Wrong image name (Should be lampepfl/dotty:2023-11-07) 😞 . Old image only contains Java 16 🤦‍♂️

@hamzaremmal
Copy link
Member Author

hamzaremmal commented Feb 15, 2024 •
edited
Loading

Note that :

  • test_windows_fast uses Java 8 (as it was previously)
  • community_build_* uses Java 8 (as it was previously)
  • scaladoc uses Java 17
  • mima uses Java 16 Java 17
  • test uses Java 16 Java 17
  • test_sbt uses Java 16 Java 17

@hamzaremmal hamzaremmal force-pushed the support-java-17 branch 3 times, most recently from 62cb0c6 to 9481aab Compare February 15, 2024 23:29
@hamzaremmal hamzaremmal mentioned this pull request Feb 15, 2024
Draft
smarter
smarter approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hamzaremmal hamzaremmal merged commit 944e73e into scala:main Feb 16, 2024
19 checks passed
@hamzaremmal hamzaremmal deleted the support-java-17 branch February 16, 2024 15:52
@hamzaremmal hamzaremmal mentioned this pull request Feb 17, 2024
Merged
hamzaremmal added a commit that referenced this pull request Feb 17, 2024
@hamzaremmal
Fix nightly build failure + Address issue with the self-hosted runner (…
6a795fd 
…#19720)

Closes #19712 

This PR introduce a workaround for actions/runner#2033. This workaround
was already introduced in #19703 in some of the jobs.

`actions/checkout` has an issue filled about this too:
actions/checkout#1169
@WojciechMazur WojciechMazur mentioned this pull request Feb 17, 2024
Closed
@Kordyjan Kordyjan added this to the 3.4.2 milestone Mar 28, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jul 1, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 2, 2024
@WojciechMazur
Backport "Switch to Java 17 in the CI" to LTS (#20921)
693bea7 
Backports #19703 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

Assignees

@hamzaremmal hamzaremmal

Labels
None yet
Projects
None yet
Milestone
3.4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@hamzaremmal @smarter @Kordyjan