Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync main with language-reference-stable #18718

Merged
merged 22 commits into from
Oct 18, 2023

Conversation

Kordyjan
Copy link
Contributor

Replaces #17614

This PR is semi-automatically generated to synchronize language-reference-stable with main.

It takes all commits from the first branch that are not present on the second and filters out all that were backported from main or have more than one parent. Then it examines changes introduced by each commit.

Changes are divided into three groups:

  • safe - those affect files in changelogs, docs, scaladoc, and scaladoc-testcases directories or any **.md file.
  • potentially safe - affect files in project direcotry
  • unsafe - all other modifications

Commits only having safe changes were cherry-picked. Those having any potentially safe changes and those that contained both safe and unsafe changes were examined individually. Other commits were skipped.

Running a script and answering about each questionable commit took less than 10 minutes, and as a result, we have no conflicts. Working on #17614 would have required hours of fixing dozens of conflicts resulting from merging changes cherry-picked from the main branch. It could also have led to subtle problems.

If there is no problem with this approach, I'll modify the script slightly and make it a part of a CI instead of the current step that tries to merge the documentation branch to main after every change.

Kordyjan and others added 22 commits October 18, 2023 15:12
reorder the source versions
[Cherry-picked 232180f]
also fixes the bullet-point under 3.3 to actually be a bullet point
[Cherry-picked 38265fc]
In the reference, in Erased Definitions, link pointed to the Inline page, even though the content is in Compile Time Operations
[Cherry-picked c54bf67]
Also fix typos in older changelogs

[Cherry-picked 9b4ea8e]
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified the changes on my side, looks good!

@Kordyjan Kordyjan merged commit e6242ca into scala:main Oct 18, 2023
16 checks passed
@Kordyjan Kordyjan deleted the reference-sync branch October 18, 2023 15:25
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
WojciechMazur added a commit that referenced this pull request Jun 22, 2024
Backports #18718 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants