Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reversed wconf parsing order to mirror scala 2 #18503

Merged
merged 1 commit into from
Sep 4, 2023
Merged

fix: reversed wconf parsing order to mirror scala 2 #18503

merged 1 commit into from
Sep 4, 2023

Conversation

johnmatthiggins
Copy link
Contributor

@johnmatthiggins johnmatthiggins commented Sep 3, 2023 •
edited
Loading

These changes should fix #18367.

@som-snytt
Copy link
Contributor

Possible home for a test

./compiler/test/dotty/tools/dotc/config/ScalaSettingsTests.scala

@johnmatthiggins johnmatthiggins force-pushed the wconf_fix branch 2 times, most recently from a4f0b10 to f49b27b Compare September 3, 2023 15:36
@johnmatthiggins johnmatthiggins changed the title [wip] fix: reversed wconf parsing order to mirror scala 2 fix: reversed wconf parsing order to mirror scala 2 Sep 3, 2023
@johnmatthiggins johnmatthiggins marked this pull request as ready for review September 3, 2023 23:27
jchyb
jchyb approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@jchyb jchyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for fixing this

@jchyb jchyb merged commit 16dd58f into scala:main Sep 4, 2023
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jul 6, 2024
Closed
@BalmungSan BalmungSan mentioned this pull request Oct 20, 2024
Open
This was referenced Nov 18, 2024
Closed
Merged
WojciechMazur added a commit that referenced this pull request Dec 2, 2024
@WojciechMazur
Backport "fix: reversed wconf parsing order to mirror scala 2" to LTS (…
097ad4a 
…#21985)

Backports #18503 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchyb jchyb jchyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

-Wconf options are processed incorrectly
4 participants
@johnmatthiggins @som-snytt @jchyb @Kordyjan