Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include .msi files in the release assets #21820

Closed
WojciechMazur opened this issue Oct 21, 2024 · 1 comment · Fixed by #21834
Closed

Include .msi files in the release assets #21820

WojciechMazur opened this issue Oct 21, 2024 · 1 comment · Fixed by #21834
Assignees
@WojciechMazur @hamzaremmal
Labels
area:ci Issues tied with CI/CD workflows area:runner Issues tied to the scala runner command. itype:enhancement

Comments

@WojciechMazur
Copy link
Contributor

Scala 3.6 can create an MSI installer, these files should be included in the release notes assets.

Additionally, a https://scala-lang.org/download/ should be updated to include link to MSI installer (but still using package managers should be recommended)
@WojciechMazur WojciechMazur added itype:enhancement area:ci Issues tied with CI/CD workflows labels Oct 21, 2024
@WojciechMazur WojciechMazur self-assigned this Oct 21, 2024
@Gedochao
Copy link
Contributor

Related to #20378 (comment)

@Gedochao Gedochao added the area:runner Issues tied to the scala runner command. label Oct 21, 2024
@WojciechMazur WojciechMazur mentioned this issue Oct 23, 2024
Merged
WojciechMazur added a commit that referenced this issue Nov 6, 2024
@WojciechMazur
Add .msi artifacts to release assets (#21834)
c4572ba 
We now include .msi files produced by `build-msi-package` in release
assets including both .msi file and it's sha256

Resolves #21820
[Cherry-picked 83c75dd]
KacperFKorban pushed a commit to dotty-staging/dotty that referenced this issue Nov 20, 2024
@WojciechMazur @KacperFKorban
Add .msi artifacts to release assets (scala#21834)
1210970 
We now include .msi files produced by `build-msi-package` in release
assets including both .msi file and it's sha256

Resolves scala#21820
KacperFKorban pushed a commit to dotty-staging/dotty that referenced this issue Nov 29, 2024
@WojciechMazur @KacperFKorban
Add .msi artifacts to release assets (scala#21834)
87756dc 
We now include .msi files produced by `build-msi-package` in release
assets including both .msi file and it's sha256

Resolves scala#21820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WojciechMazur WojciechMazur

@hamzaremmal hamzaremmal

Labels
area:ci Issues tied with CI/CD workflows area:runner Issues tied to the scala runner command. itype:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add .msi artifacts to release assets WojciechMazur/dotty
3 participants
@Gedochao @WojciechMazur @hamzaremmal