Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open object is allowed despite not doing anything #21760

Closed
KacperFKorban opened this issue Oct 14, 2024 · 2 comments · Fixed by #21922
Closed

open object is allowed despite not doing anything #21760

KacperFKorban opened this issue Oct 14, 2024 · 2 comments · Fixed by #21922
Assignees
@SethTisue
Labels
area:linting Linting warnings enabled with -W or -Xlint itype:bug Spree Suitable for a future Spree
Milestone
3.6.3

Comments

@KacperFKorban
Copy link
Member

Compiler version

3.6.1-RC1-bin-20241011-5e7ab15-NIGHTLY

Minimized code

//> using scala 3.nightly
  
open object O // no effect

Output

Successful compilation.

Expectation

Warning or error that open objects trivially cannot be extended.

Other info

This check should most likely be done in Desugar.scala#checkModifiers or somewhere in Checking.scala (maybe checkWellFormed)
@KacperFKorban KacperFKorban added itype:bug area:linting Linting warnings enabled with -W or -Xlint Spree Suitable for a future Spree labels Oct 14, 2024
@mbovel
Copy link
Member

mbovel commented Nov 9, 2024

This issue was picked for the Scala Issue Spree of Monday, November 11th. @SethTisue and @HarrisL2 will be working on it. If you have any insight into the issue or guidance on how to fix it, please leave it here.

@SethTisue
Copy link
Member

sealed object errors in both Scala 2 and 3, so that seems like precedent that we should error on this too, since the combination is equally nonsensical (rather than merely redundant)

HarrisL2 added a commit to HarrisL2/scala3 that referenced this issue Nov 11, 2024
@HarrisL2
Check for open flag on objects
d9b8da5 
Fixes scala#21760
@HarrisL2 HarrisL2 mentioned this issue Nov 11, 2024
Merged
hamzaremmal added a commit that referenced this issue Nov 11, 2024
@hamzaremmal
Disallow open modifier on objects (#21922)
1947828 
Fixes #21760
KacperFKorban pushed a commit to dotty-staging/dotty that referenced this issue Nov 20, 2024
@HarrisL2 @KacperFKorban
Check for open flag on objects
e92a787 
Fixes scala#21760
@WojciechMazur WojciechMazur added this to the 3.6.3 milestone Nov 25, 2024
KacperFKorban pushed a commit to dotty-staging/dotty that referenced this issue Nov 29, 2024
@HarrisL2 @KacperFKorban
Check for open flag on objects
33f58dd 
Fixes scala#21760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SethTisue SethTisue

Labels
area:linting Linting warnings enabled with -W or -Xlint itype:bug Spree Suitable for a future Spree
Projects
None yet
Milestone
3.6.3
Development

Successfully merging a pull request may close this issue.

Disallow open modifier on objects HarrisL2/scala3
4 participants
@SethTisue @mbovel @WojciechMazur @KacperFKorban