-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong unimplemented members reported #21335
Labels
Milestone
Comments
Duhemm
added
itype:bug
stat:needs triage
Every issue needs to have an "area" and "itype" label
labels
Aug 6, 2024
Duhemm
added a commit
to Duhemm/dotty
that referenced
this issue
Aug 6, 2024
Previously, when a concrete class A had unimplemented members that are overridden, all overrides would be reported as unimplemented in the error message. This would produce error messages that are not accurate, and that suggest stubs that are not correct. This patch fixes the issue by reporting in the error message only the unimplemented members that are not overridden by other unimplemented members. Fixes scala#21335
Gedochao
added
area:overloading
and removed
stat:needs triage
Every issue needs to have an "area" and "itype" label
labels
Aug 8, 2024
sjrd
added a commit
that referenced
this issue
Aug 8, 2024
Previously, when a concrete class A had unimplemented members that are overridden, all overrides would be reported as unimplemented in the error message. This would produce error messages that are not accurate, and that suggest stubs that are not correct. This patch fixes the issue by reporting in the error message only the unimplemented members that are not overridden by other unimplemented members. Fixes #21335
WojciechMazur
pushed a commit
that referenced
this issue
Aug 28, 2024
Previously, when a concrete class A had unimplemented members that are overridden, all overrides would be reported as unimplemented in the error message. This would produce error messages that are not accurate, and that suggest stubs that are not correct. This patch fixes the issue by reporting in the error message only the unimplemented members that are not overridden by other unimplemented members. Fixes #21335 [Cherry-picked 0d50a30]
WojciechMazur
pushed a commit
that referenced
this issue
Dec 2, 2024
Previously, when a concrete class A had unimplemented members that are overridden, all overrides would be reported as unimplemented in the error message. This would produce error messages that are not accurate, and that suggest stubs that are not correct. This patch fixes the issue by reporting in the error message only the unimplemented members that are not overridden by other unimplemented members. Fixes #21335 [Cherry-picked 0d50a30]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Compiler version
3.4.2
Minimized code
Output
Expectation
I expected only a single unimplemented member to be reported,
override def x(): Bar = ???
, which is what I get with Scala 2.The text was updated successfully, but these errors were encountered: