Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro API Quotes#DefDefMethods is missing tpt #16960

Closed
pweisenburger opened this issue Feb 19, 2023 · 1 comment · Fixed by #16974
Closed

Macro API Quotes#DefDefMethods is missing tpt #16960

pweisenburger opened this issue Feb 19, 2023 · 1 comment · Fixed by #16974
Labels
area:metaprogramming:reflection Issues related to the quotes reflection API itype:enhancement
Milestone
3.4.0

Comments

@pweisenburger
Copy link
Contributor

Compiler version

3.3.1-RC1-bin-20230216-2507577-NIGHTLY

Expectation

What the title says. ValDefMethods has a tpt member but it is missing from DefDefMethods. I was also thinking whether it would make sense to have a ValOrDefDef common super type for ValDef and DefDef (I find myself often writing ValDef | DefDef). This would hep abstracting over the common members, i.e., tpt and rhs.
@pweisenburger pweisenburger added the stat:needs triage Every issue needs to have an "area" and "itype" label label Feb 19, 2023
@nicolasstucki nicolasstucki added area:metaprogramming:reflection Issues related to the quotes reflection API itype:enhancement and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Feb 20, 2023
@nicolasstucki
Copy link
Contributor

DefDefMethods has returnTpt.

Adding ValOrDefDef with tpt and rhs makes sense. In that case we would not require DefDefMethods.tpt.

nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Feb 20, 2023
@nicolasstucki
Add reflect.ValOrDefDef
5f204e6 
Closes scala#16960
@nicolasstucki nicolasstucki mentioned this issue Feb 20, 2023
Merged
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 25, 2023
@nicolasstucki
Add reflect.ValOrDefDef
eb66f8f 
Closes scala#16960
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 25, 2023
@nicolasstucki
Add reflect.ValOrDefDef
3f17727 
Closes scala#16960
smarter added a commit that referenced this issue Jul 31, 2023
@smarter
Add reflect.ValOrDefDef (#16974)
46fc22b 
Closes #16960
@Kordyjan Kordyjan added this to the 3.4.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:metaprogramming:reflection Issues related to the quotes reflection API itype:enhancement
Projects
None yet
Milestone
3.4.0
Development

Successfully merging a pull request may close this issue.

Add reflect.ValOrDefDef dotty-staging/dotty
3 participants
@pweisenburger @nicolasstucki @Kordyjan