Skip to content

Commit

Permalink
Do not warn about expected missing positions in quotes reflect.Symbol…
Browse files Browse the repository at this point in the history
…s.pos
jchyb committed Nov 7, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent 4ae5d61 commit caac72a
Showing 3 changed files with 15 additions and 1 deletion.
3 changes: 2 additions & 1 deletion compiler/src/scala/quoted/runtime/impl/QuotesImpl.scala
Original file line number Diff line number Diff line change
@@ -2698,9 +2698,10 @@ class QuotesImpl private (using val ctx: Context) extends Quotes, QuoteUnpickler
if self.exists then
val symPos = self.sourcePos
if symPos.exists then Some(symPos)
else
else if self.source.exists then
if xCheckMacro then report.warning(s"Missing symbol position (defaulting to position 0): $self\nThis is a compiler bug. Please report it.")
Some(self.source.atSpan(dotc.util.Spans.Span(0)))
else None
else None

def docstring: Option[String] =
10 changes: 10 additions & 0 deletions tests/pos-macros/i21672/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
object Repro {
inline def apply(): Unit = ${ applyImpl }

import scala.quoted.*
def applyImpl(using q: Quotes): Expr[Unit] = {
import q.reflect.*
report.info(TypeRepr.of[Some[String]].typeSymbol.pos.toString)
'{ () }
}
}
3 changes: 3 additions & 0 deletions tests/pos-macros/i21672/Test_2.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
//> using options -Xfatal-warnings
object Test:
Repro()

0 comments on commit caac72a

Please sign in to comment.