fix: report correct location on a repeat modifier (#17982)

Currently given the following code snippet: ```scala final final case class Foo() ``` The error is reported on `Foo` and not on the repeated modifier. This changes the reporting to instead report on the repeated modifier `final`. Fixes #17981 [Cherry-picked 10180da]
scala · Nov 29, 2023 · 6fb812a · 6fb812a
1 parent 3f693f7
commit 6fb812a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/compiler/src/dotty/tools/dotc/parsing/Parsers.scala b/compiler/src/dotty/tools/dotc/parsing/Parsers.scala
@@ -3028,7 +3028,9 @@ object Parsers {
       val name = in.name
       val mod = atSpan(in.skipToken()) { modOfToken(tok, name) }
 
-      if (mods.isOneOf(mod.flags)) syntaxError(RepeatedModifier(mod.flags.flagsString))
+      if mods.isOneOf(mod.flags) then
+        syntaxError(RepeatedModifier(mod.flags.flagsString), mod.span)
+
       addMod(mods, mod)
     }
 

diff --git a/tests/neg/i17981.check b/tests/neg/i17981.check
@@ -0,0 +1,6 @@
+-- [E015] Syntax Error: tests/neg/i17981.scala:1:6 ---------------------------------------------------------------------
+1 |final final case class Foo() // error
+  |      ^^^^^
+  |      Repeated modifier final
+  |
+  | longer explanation available when compiling with `-explain`
diff --git a/tests/neg/i17981.scala b/tests/neg/i17981.scala
@@ -0,0 +1 @@
+final final case class Foo() // error