Avoid call to inaccessible protected java method through self type #10794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TIL scala-dev#143. This changes super invocation of java interface to in the run test in |
With a self type `self: J =>`, calling a method `this.p` which is protected and defined in Java is not valid and results in an `IllegalAccessError` at runtime. If the class with the self type overrides the method, use that class as the receiver type. Otherwise issue an error.
|
Moved my change to be more local, le compilateur is a bit touchy around here. |
retronym
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a self type
self: J =>, calling a methodthis.pwhich is protected and defined in Java is not valid and results in anIllegalAccessErrorat runtime.If the class with the self type overrides the method, use that class as the receiver type. Otherwise issue an error.
Fixes scala/bug#13007