Use Visual Studio 2015 for Node 6+

[xzyfer]

Node change to Visual Studio 2015 when Node 6 went to LTS.

See nodejs/node#7989
Fixes #1854

[nschonni]

Beat me to it 😄
Two things but I can't comment on the line since it's out of the diff

• The tag matrix above should be updated too
• Confirm if the --msvs_version=2013 should be changed

[xzyfer]

The tag matrix above should be updated too

Yeah, I'm just confirming this syntax is even valid. The docs are non-existent on this use case.

Confirm if the --msvs_version=2013 should be changed

True.

[nschonni]

Not sure if it would be faster to spit the matrix with os: Visual Studio 2015

[xzyfer]

You might be right. It's easy enough to test.

[nschonni]

Think you got this reversed. These ones should be 2015

[xzyfer]

Yep 😞

[xzyfer]

The builds appear to be comparable. I've opted ENV vars just because GYP_MSVS_VERSION needs to be an ENV var also.

[xzyfer]

Paging @am11 and @saper for a sanity check

[nschonni]

Sounds good, I'm just playing with something else for fun

[nschonni]

Not sure if it's picking it up properly, it looks like it's going back to auto https://ci.appveyor.com/project/sass/node-sass/build/2412/job/eecvsxmwbfyaawjy#L243

[nschonni]

Not sure if it was changing the os: from the global to the matrix, or adding back the --msvcs flag, but this was working nschonni@a2f420f

[xzyfer]

The node-gyp code suggest GYP_MSVS_VERSION should be enough. If msvs_version defaults to "auto" if not set. If the msvs version is auto when GYP_MSVS_VERSION is looked up. I'm digging in a little more atm.

[xzyfer]

Looks like the ENV vars don't cascade which is what was tripping me up.

[am11]

Great, thanks Mike! 👍