Update relative pathToFileURL to match node #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkme
force-pushed
the
update-path-to-file-url
branch
from
d63f98e to
e11a1e7
Compare
nex3
reviewed
Dec 11, 2024
lib/src/utils.ts
Outdated
| } | ||
|
|
||
| if (process.platform === 'win32') { | ||
| fileUrl = fileUrl.replace(/%5C/g, '/').replace(/\\/g, '/'); |
There was a problem hiding this comment.
This is changing the behavior even for previous Node versions. Previously we always replaced backslash with forward slash, now we're only doing it on Windows. Is that intentional?
There was a problem hiding this comment.
Yes. fileURLToPath on linux has \ escaped as %5C, and in the previous implementation you can see that only on windows it's reverting the escape of %5C, meaning .replace(/\\/g, '/') on linux actually did nothing.
There was a problem hiding this comment.
In fact, .replace(/\\/g, '/') seems to be unnecessary, as I'm now replacing %5C (backslash) directly with / (forward slash).
nex3
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node recently changed what is escaped and what is not in pathToFileURL, causing tests to fail on node 22 LTS and higher:
nodejs/node#54545