Skip to content

Commit

Permalink
Only claim "package:" URLs are unsupported on Node
Browse files Browse the repository at this point in the history
Closes #630
  • Loading branch information
nex3 committed Apr 3, 2019
1 parent 9999835 commit c799620
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.17.5

* Don't claim that "package:" URLs aren't supported when they actually are.

## 1.17.4

* Consistently parse U+000C FORM FEED, U+000D CARRIAGE RETURN, and sequences of
Expand Down
3 changes: 2 additions & 1 deletion lib/src/visitor/async_evaluate.dart
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import '../extend/extender.dart';
import '../importer.dart';
import '../importer/node.dart';
import '../importer/utils.dart';
import '../io.dart';
import '../logger.dart';
import '../parse/keyframe_selector.dart';
import '../syntax.dart';
Expand Down Expand Up @@ -851,7 +852,7 @@ class _EvaluateVisitor
if (tuple != null) return tuple;
}

if (url.startsWith('package:')) {
if (url.startsWith('package:') && isNode) {
// Special-case this error message, since it's tripped people up in the
// past.
throw "\"package:\" URLs aren't supported on this platform.";
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: sass
version: 1.17.4
version: 1.17.5-dev
description: A Sass implementation in Dart.
author: Dart Team <[email protected]>
homepage: https://github.com/sass/dart-sass
Expand Down

0 comments on commit c799620

Please sign in to comment.