-
Notifications
You must be signed in to change notification settings - Fork 8
Treat null importer as noOp if url is not a file: url #83
Conversation
I think the desirable behavior here, to match the JS API spec as updated in sass/sass#3278, is to set a |
I think the language I picked matches the current behavior: the js-api (non-embedded) only checks if Today (non-embedded js-api):
If I understand your proposal correctly:
@nex3 Is that what you mean? In that case we also need to update the non-embedded js-api. |
Since this provides a substantial amount of the Node embedded implementation, it's sometimes necessary to test that updates continue to pass (or begin to pass) the JS API tests, as for example in #83.
Since this provides a substantial amount of the Node embedded implementation, it's sometimes necessary to test that updates continue to pass (or begin to pass) the JS API tests, as for example in #83.
Since this provides a substantial amount of the Node embedded implementation, it's sometimes necessary to test that updates continue to pass (or begin to pass) the JS API tests, as for example in #83.
@ntkme Looks like this is breaking some legacy importer tests, can you take a look? |
@nex3 Looks like we need sass/embedded-host-node#128. The legacy can resolve from working directory without filename set (meaning no file: url). In other words, it always needs a FileSystemImporter. |
This PR fixes #82.
See sass/sass-spec#1785
See sass/embedded-host-node#128