Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add myself as a contributor #297

Merged
merged 1 commit into from
Jun 24, 2018
Merged

chore: add myself as a contributor #297

merged 1 commit into from
Jun 24, 2018

Conversation

ljharb
Copy link
Collaborator

@ljharb ljharb commented Jun 24, 2018

No description provided.

@ljharb ljharb requested a review from ta2edchimp June 24, 2018 17:29
@ljharb ljharb merged commit 7d816d6 into sarbbottam:master Jun 24, 2018
@ljharb ljharb deleted the contrib branch June 24, 2018 22:03
@ljharb
Copy link
Collaborator Author

ljharb commented Jun 24, 2018

@ta2edchimp i'm trying to make a release, but i'm not sure how i'm supposed to do it. is it documented anywhere?

@ta2edchimp
Copy link
Collaborator

Unfortunately, it's not (yet) documented. We removed the automatic release using semantic-release, but never updated the docs.

  • I usually tag the version npm version (major|minor|patch),
  • build all the things npm run build
  • and publish the release npm publish

@ljharb
Copy link
Collaborator Author

ljharb commented Jun 25, 2018

Sounds great, will do

@ljharb
Copy link
Collaborator Author

ljharb commented Jun 25, 2018

Done in #299 and #300.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ta2edchimp ta2edchimp ta2edchimp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljharb @ta2edchimp