Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove media parsers #616

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Aug 27, 2024

  • Added ApiRequest#asWeb()
  • Added ApiRequest#readBody()
  • Added ApiRequest#readBodyArrayBuffer()
  • Added ApiRequest#readBodyBlob()
  • Added ApiRequest#readBodyFormData()
  • Added ApiRequest#readBodyJson()
  • Added ApiRequest#readBodyText()
  • Added ApiRequest#readValidatedBody()
  • Added ApiRequest#readValidatedBodyFormData()
  • Added ApiRequest#readValidatedBodyJson()
  • Added ApiRequest#readValidatedBodyText()
  • Added 'QUERY' to the list of method names
  • Fixed issue in Server#disconnect()
  • 🔥 BREAKING CHANGE: Removed MediaParser
  • 🔥 BREAKING CHANGE: Removed MediaParserStore
  • 🔥 BREAKING CHANGE: Removed Route#acceptedContentMimeTypes
  • 🔥 BREAKING CHANGE: Removed ApiRequest#body, use the new methods instead

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't get the purpose of URLProxy...

packages/api/src/lib/structures/api/ApiRequest.ts Outdated Show resolved Hide resolved
packages/api/src/lib/structures/api/ApiRequest.ts Outdated Show resolved Hide resolved
packages/api/src/lib/utils/_body/RequestProxy.ts Outdated Show resolved Hide resolved
packages/api/src/lib/utils/_body/RequestProxy.ts Outdated Show resolved Hide resolved
@kyranet kyranet force-pushed the refactor/remove-media-parsers branch from 189ef0d to 37fe84e Compare August 27, 2024 17:52
Added `ApiRequest#asWeb()`
Added `ApiRequest#readBody()`
Added `ApiRequest#readBodyArrayBuffer()`
Added `ApiRequest#readBodyBlob()`
Added `ApiRequest#readBodyFormData()`
Added `ApiRequest#readBodyJson()`
Added `ApiRequest#readBodyText()`
Added `ApiRequest#readValidatedBody()`
Added `ApiRequest#readValidatedBodyFormData()`
Added `ApiRequest#readValidatedBodyJson()`
Added `ApiRequest#readValidatedBodyText()`
Added `'QUERY'` to the list of method names
Fixed issue in `Server#disconnect()`

BREAKING CHANGE: Removed `MediaParser`
BREAKING CHANGE: Removed `MediaParserStore`
BREAKING CHANGE: Removed `Route#acceptedContentMimeTypes`
BREAKING CHANGE: Removed `ApiRequest#body`, use the new methods instead
@kyranet kyranet force-pushed the refactor/remove-media-parsers branch from 37fe84e to 018c7e1 Compare August 27, 2024 17:55
Copy link

@kyranet kyranet requested a review from vladfrangu August 27, 2024 18:03
@kyranet kyranet merged commit 56b0ad1 into main Sep 6, 2024
8 checks passed
@kyranet kyranet deleted the refactor/remove-media-parsers branch September 6, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants