generated from sapphiredev/sapphire-template
-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove media parsers #616
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladfrangu
previously requested changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also don't get the purpose of URLProxy...
kyranet
force-pushed
the
refactor/remove-media-parsers
branch
from
August 27, 2024 17:52
189ef0d
to
37fe84e
Compare
Added `ApiRequest#asWeb()` Added `ApiRequest#readBody()` Added `ApiRequest#readBodyArrayBuffer()` Added `ApiRequest#readBodyBlob()` Added `ApiRequest#readBodyFormData()` Added `ApiRequest#readBodyJson()` Added `ApiRequest#readBodyText()` Added `ApiRequest#readValidatedBody()` Added `ApiRequest#readValidatedBodyFormData()` Added `ApiRequest#readValidatedBodyJson()` Added `ApiRequest#readValidatedBodyText()` Added `'QUERY'` to the list of method names Fixed issue in `Server#disconnect()` BREAKING CHANGE: Removed `MediaParser` BREAKING CHANGE: Removed `MediaParserStore` BREAKING CHANGE: Removed `Route#acceptedContentMimeTypes` BREAKING CHANGE: Removed `ApiRequest#body`, use the new methods instead
kyranet
force-pushed
the
refactor/remove-media-parsers
branch
from
August 27, 2024 17:55
37fe84e
to
018c7e1
Compare
Quality Gate passedIssues Measures |
favna
approved these changes
Aug 29, 2024
vladfrangu
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ApiRequest#asWeb()
ApiRequest#readBody()
ApiRequest#readBodyArrayBuffer()
ApiRequest#readBodyBlob()
ApiRequest#readBodyFormData()
ApiRequest#readBodyJson()
ApiRequest#readBodyText()
ApiRequest#readValidatedBody()
ApiRequest#readValidatedBodyFormData()
ApiRequest#readValidatedBodyJson()
ApiRequest#readValidatedBodyText()
'QUERY'
to the list of method namesServer#disconnect()
MediaParser
MediaParserStore
Route#acceptedContentMimeTypes
ApiRequest#body
, use the new methods instead