refactor(route)!: change method handling #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
force-pushed
the
refactor/change-method-handling
branch
from
bd104f9 to
ca2412b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
==========================================
+ Coverage 36.79% 36.87% +0.08%
==========================================
Files 106 107 +1
Lines 7738 7767 +29
Branches 89 88 -1
==========================================
+ Hits 2847 2864 +17
- Misses 4890 4902 +12
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyranet
force-pushed
the
refactor/change-method-handling
branch
2 times, most recently
from
913aaa6 to
74da8e4
Compare
Added support for specifying a route's supported methods in the options Added support for specifying a route's method in the file name Added `MediaParser.Request` and `MediaParser.Response` type aliases Added `Middleware.Request` and `Middleware.Response` type aliases Hardened the `onLoad` and `onUnload` hooks from the `Route` class BREAKING CHANGE: The headers middleware now uses the supported HTTP methods from the route or the store instead of sending all supported methods BREAKING CHANGE: Changed the method handling in the `Route` class to not be keyed by the method name, sending all requests to the `run` method. This allows for more flexibility in the route handling BREAKING CHANGE: Writing the name of a file as `<name>.<method>.ts` will now set `<method>` as a method for the route
kyranet
force-pushed
the
refactor/change-method-handling
branch
from
74da8e4 to
86dd9c4
Compare
favna
approved these changes
Jun 29, 2024
Co-authored-by: Jeroen Claassens <[email protected]>
favna
previously approved these changes
Jun 29, 2024
vladfrangu
requested changes
Jun 29, 2024
vladfrangu
approved these changes
Jun 29, 2024
favna
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MediaParser.RequestandMediaParser.Responsetype aliasesMiddleware.RequestandMiddleware.Responsetype aliasesonLoadandonUnloadhooks from theRouteclassRouteclass to not be keyed by the method name, sending all requests to therunmethod. This allows for more flexibility in the route handling<name>.<method>.tswill now set<method>as a method for the route👀
