14034: Eliminate assumption of mutable list argument in SeleniumManag…

…er.getBinaryPaths() (SeleniumHQ#14036) 14034: Eliminate assumption of mutable list argument Co-authored-by: Diego Molina <[email protected]>
sandeepsuryaprasad · Oct 29, 2024 · 95754f2 · 95754f2
1 parent 8f5a967
commit 95754f2
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/java/src/org/openqa/selenium/manager/SeleniumManager.java b/java/src/org/openqa/selenium/manager/SeleniumManager.java
@@ -28,6 +28,7 @@
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.time.Duration;
+import java.util.ArrayList;
 import java.util.List;
 import java.util.Properties;
 import java.util.logging.Level;
@@ -232,16 +233,18 @@ private synchronized Path getBinary() {
    * @return the locations of the assets from Selenium Manager execution
    */
   public Result getBinaryPaths(List<String> arguments) {
-    arguments.add("--language-binding");
-    arguments.add("java");
-    arguments.add("--output");
-    arguments.add("json");
+    List<String> args = new ArrayList<>(arguments.size() + 5);
+    args.addAll(arguments);
+    args.add("--language-binding");
+    args.add("java");
+    args.add("--output");
+    args.add("json");
 
     if (getLogLevel().intValue() <= Level.FINE.intValue()) {
-      arguments.add("--debug");
+      args.add("--debug");
     }
 
-    return runCommand(getBinary(), arguments);
+    return runCommand(getBinary(), args);
   }
 
   private Level getLogLevel() {