[build] update rules_dotnet to 0.15.1 (SeleniumHQ#14096)

sandeepsuryaprasad · Oct 29, 2024 · 8d26ed8 · 8d26ed8
1 parent 0e68742
commit 8d26ed8
Show file tree

Hide file tree

Showing 12 changed files with 50 additions and 143 deletions.
diff --git a/MODULE.bazel b/MODULE.bazel
@@ -10,7 +10,7 @@ bazel_dep(name = "bazel_skylib", version = "1.5.0")
 bazel_dep(name = "buildifier_prebuilt", version = "6.4.0")
 bazel_dep(name = "contrib_rules_jvm", version = "0.24.0")
 bazel_dep(name = "platforms", version = "0.0.10")
-bazel_dep(name = "rules_dotnet", version = "0.14.0")
+bazel_dep(name = "rules_dotnet", version = "0.15.1")
 bazel_dep(name = "rules_java", version = "7.4.0")
 bazel_dep(name = "rules_jvm_external", version = "6.1")
 bazel_dep(name = "rules_nodejs", version = "6.0.5")

diff --git a/dotnet/paket.bzl b/dotnet/paket.bzl
diff --git a/dotnet/paket.nuget.bzl b/dotnet/paket.nuget.bzl
diff --git a/dotnet/paket.nuget_extension.bzl b/dotnet/paket.nuget_extension.bzl
@@ -1,4 +1,4 @@
-"Generated by paket2bazel"
+"Generated"
 
 load(":paket.nuget.bzl", _nuget = "nuget")
 

diff --git a/dotnet/src/support/BUILD.bazel b/dotnet/src/support/BUILD.bazel
@@ -39,9 +39,6 @@ csharp_library(
     target_frameworks = [
         "netstandard2.0",
     ],
-    targeting_packs = [
-        framework("nuget", "NETStandard.Library"),
-    ],
     visibility = [
         "//dotnet:__subpackages__",
     ],
@@ -82,9 +79,6 @@ csharp_library(
     target_frameworks = [
         "netstandard2.0",
     ],
-    targeting_packs = [
-        framework("nuget", "NETStandard.Library"),
-    ],
     visibility = [
         "//dotnet:__subpackages__",
     ],

diff --git a/dotnet/src/webdriver/BUILD.bazel b/dotnet/src/webdriver/BUILD.bazel
@@ -47,9 +47,6 @@ csharp_library(
     target_frameworks = [
         "netstandard2.0",
     ],
-    targeting_packs = [
-        framework("nuget", "NETStandard.Library"),
-    ],
     visibility = [
         "//dotnet:__subpackages__",
     ],
@@ -79,9 +76,6 @@ csharp_library(
     target_frameworks = [
         "netstandard2.0",
     ],
-    targeting_packs = [
-        framework("nuget", "NETStandard.Library"),
-    ],
     visibility = [
         "//dotnet:__subpackages__",
     ],

diff --git a/dotnet/test/common/BUILD.bazel b/dotnet/test/common/BUILD.bazel
@@ -46,9 +46,6 @@ csharp_library(
         "//common/manager:selenium-manager-macos",
     ],
     target_frameworks = ["net7.0"],
-    targeting_packs = [
-        framework("nuget", "Microsoft.NETCore.App.Ref"),
-    ],
     visibility = [
         "//dotnet/test:__subpackages__",
     ],
@@ -89,9 +86,6 @@ dotnet_nunit_test_suite(
         ":test-data",
     ],
     target_frameworks = ["net7.0"],
-    targeting_packs = [
-        framework("nuget", "Microsoft.NETCore.App.Ref"),
-    ],
     deps = [
         ":fixtures",
         "//dotnet/src/webdriver",

diff --git a/dotnet/test/support/Events/BUILD.bazel b/dotnet/test/support/Events/BUILD.bazel
@@ -9,9 +9,6 @@ dotnet_nunit_test_suite(
     size = "small",
     srcs = SMALL_TESTS,
     target_frameworks = ["net7.0"],
-    targeting_packs = [
-        framework("nuget", "NETStandard.Library"),
-    ],
     deps = [
         "//dotnet/src/support",
         "//dotnet/src/webdriver",
@@ -40,9 +37,6 @@ dotnet_nunit_test_suite(
         "//dotnet/test/common:test-data",
     ],
     target_frameworks = ["net7.0"],
-    targeting_packs = [
-        framework("nuget", "NETStandard.Library"),
-    ],
     deps = [
         "//dotnet/src/support",
         "//dotnet/src/webdriver",

diff --git a/dotnet/test/support/Extensions/BUILD.bazel b/dotnet/test/support/Extensions/BUILD.bazel
@@ -5,9 +5,6 @@ dotnet_nunit_test_suite(
     size = "small",
     srcs = glob(["*.cs"]),
     target_frameworks = ["net7.0"],
-    targeting_packs = [
-        framework("nuget", "NETStandard.Library"),
-    ],
     deps = [
         "//dotnet/src/support",
         "//dotnet/src/webdriver",

diff --git a/dotnet/test/support/UI/BUILD.bazel b/dotnet/test/support/UI/BUILD.bazel
@@ -14,9 +14,6 @@ dotnet_nunit_test_suite(
     size = "small",
     srcs = SMALL_TESTS,
     target_frameworks = ["net7.0"],
-    targeting_packs = [
-        framework("nuget", "NETStandard.Library"),
-    ],
     deps = [
         "//dotnet/src/support",
         "//dotnet/src/webdriver",
@@ -45,9 +42,6 @@ dotnet_nunit_test_suite(
         "//dotnet/test/common:test-data",
     ],
     target_frameworks = ["net7.0"],
-    targeting_packs = [
-        framework("nuget", "NETStandard.Library"),
-    ],
     deps = [
         "//dotnet/src/support",
         "//dotnet/src/webdriver",

diff --git a/dotnet/update-deps.sh b/dotnet/update-deps.sh
@@ -5,5 +5,5 @@ SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
 (
     cd "$SCRIPT_DIR" || exit 1
     (dotnet tool restore && dotnet tool run paket install)
-    bazel run @rules_dotnet//tools/paket2bazel:paket2bazel.exe -- --dependencies-file "$(pwd)"/paket.dependencies --output-folder "$(pwd)"
+    bazel run @rules_dotnet//tools/paket2bazel:paket2bazel -- --dependencies-file "$(pwd)"/paket.dependencies --output-folder "$(pwd)"
 )
diff --git a/third_party/dotnet/devtools/src/generator/BUILD.bazel b/third_party/dotnet/devtools/src/generator/BUILD.bazel
@@ -5,9 +5,6 @@ csharp_binary(
     srcs = glob(["**/*.cs"]),
     # Used as a tool in our build, so just target one framework
     target_frameworks = ["net7.0"],
-    targeting_packs = [
-        framework("nuget", "Microsoft.NETCore.App.Ref"),
-    ],
     visibility = [
         "//dotnet:__subpackages__",
     ],