Skip to content

Commit

Permalink
[grid] Set session-request-timeout as client readTimeout in RemoteNew…
Browse files Browse the repository at this point in the history
…SessionQueue (SeleniumHQ#14272)

Signed-off-by: Viet Nguyen Duc <[email protected]>
  • Loading branch information
VietND96 authored and sandeepsuryaprasad committed Oct 29, 2024
1 parent cc8f4a4 commit 57e212e
Showing 1 changed file with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

package org.openqa.selenium.grid.sessionqueue.remote;

import static org.openqa.selenium.remote.http.ClientConfig.defaultConfig;
import static org.openqa.selenium.remote.http.HttpMethod.DELETE;
import static org.openqa.selenium.remote.http.HttpMethod.GET;
import static org.openqa.selenium.remote.http.HttpMethod.POST;
Expand All @@ -25,6 +26,7 @@
import java.lang.reflect.Type;
import java.net.MalformedURLException;
import java.net.URI;
import java.time.Duration;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand All @@ -48,6 +50,7 @@
import org.openqa.selenium.internal.Require;
import org.openqa.selenium.json.Json;
import org.openqa.selenium.json.TypeToken;
import org.openqa.selenium.remote.http.ClientConfig;
import org.openqa.selenium.remote.http.Contents;
import org.openqa.selenium.remote.http.Filter;
import org.openqa.selenium.remote.http.HttpClient;
Expand Down Expand Up @@ -77,14 +80,17 @@ public RemoteNewSessionQueue(Tracer tracer, HttpClient client, Secret registrati
public static NewSessionQueue create(Config config) {
Tracer tracer = new LoggingOptions(config).getTracer();
URI uri = new NewSessionQueueOptions(config).getSessionQueueUri();
Duration sessionRequestTimeout = new NewSessionQueueOptions(config).getSessionRequestTimeout();
HttpClient.Factory clientFactory = new NetworkOptions(config).getHttpClientFactory(tracer);

SecretOptions secretOptions = new SecretOptions(config);
Secret registrationSecret = secretOptions.getRegistrationSecret();

try {
ClientConfig clientConfig =
defaultConfig().readTimeout(sessionRequestTimeout).baseUrl(uri.toURL());
return new RemoteNewSessionQueue(
tracer, clientFactory.createClient(uri.toURL()), registrationSecret);
tracer, clientFactory.createClient(clientConfig), registrationSecret);
} catch (MalformedURLException e) {
throw new UncheckedIOException(e);
}
Expand Down

0 comments on commit 57e212e

Please sign in to comment.