Fixed the display problem of Sandman. #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIRC this lines of code are required to switch back from the "pizza" background |
Is there a specific step? After commenting these lines of code, I tried to manually set the background to "pizza" and switch back, and I did not encounter an error. |
|
Indeed, i think there is a change to before, earlier it was posible to switch back from pizza without rebuilding the UI but now we just rebuild the UI for all major UI changes making that code obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem triggered if the system color changes after Sandman starts in a dark color.
This issue has existed in multiple past versions.
I think these lines of code are redundant, but it brings up this display error. Please let me know if I've overlooked something.