Cleanup Sandboxie-Plus.ini configuration

[okrc]

Fix #2231

[DavidXanatos]

c19bda4
and
3e406dc
does not seam to be needed the box object being held by a smart pointer will be available until it goes out of scope so name does not need to be cached

Explicitly deleting SizeCache entries is an improvement, but it does not handle the case where a box is deleted manually from the ini or using the old classic ui.
It would be best to add a clean up routine here

Sandboxie/SandboxiePlus/SandMan/SandMan.cpp

Line 1600 in e5d1fab

if (!Status.IsError() && !theAPI->GetAllBoxes().contains("defaultbox")) {

such that on start/connect once we have a list of all existing boxes we purge the size cache.

I'll add this to the next build

		if (!Status.IsError()) {

			auto AllBoxes = theAPI->GetAllBoxes();

			foreach(const QString & Key, theConf->ListKeys("SizeCache")) {
				if (!AllBoxes.contains(Key.toLower()))
					theConf->DelValue("SizeCache/" + Key);
			}

			if (!AllBoxes.contains("defaultbox")) {
				OnLogMessage(tr("Default sandbox not found; creating: %1").arg("DefaultBox"));
				theAPI->CreateBox("DefaultBox");
			}
		}

[okrc]

@DavidXanatos
This PR doesn't do much more with SizeCache.
I will remove all changes to SizeCache.

c19bda4 and 3e406dc does not seam to be needed the box object being held by a smart pointer will be available until it goes out of scope so name does not need to be cached

Explicitly deleting SizeCach

I don't understand here, is that meant?

a8cdb40
is an additional issue. The names are not determined and escaped for these matches.

[okrc]

I'll add this to the next build

		if (!Status.IsError()) {

			auto AllBoxes = theAPI->GetAllBoxes();

			foreach(const QString & Key, theConf->ListKeys("SizeCache")) {
				if (!AllBoxes.contains(Key.toLower()))
					theConf->DelValue("SizeCache/" + Key);
			}

			if (!AllBoxes.contains("defaultbox")) {
				OnLogMessage(tr("Default sandbox not found; creating: %1").arg("DefaultBox"));
				theAPI->CreateBox("DefaultBox");
			}
		}

这里还有一些问题，关闭统计后SizeCache依旧存在，但是Value已经不再更新。

There are still some problems here, after closing Count the SizeCache still exists, but the Value is no longer updated.

[DavidXanatos]

I merged the changes and fixed a few things that did not seam right, also added an improved handling of the size cache

[isaak654]

@DavidXanatos In PRs like this one, I would advise in the next future to use the "Squash and merge" type of merging instead of the traditional "Create a merge commit":

The first one is more chaotic when there is a certain number of commits in the same PR.

[okrc]

@DavidXanatos
5275277

			foreach(const QString & Key, theConf->ListKeys("SizeCache")) {
				if (!AllBoxes.contains(Key.toLower()))
					theConf->DelValue("SizeCache/" + Key);
			}

When the WatchBoxSize is modified, the handling should change here. For example:

			if (theConf->GetBool("Options/WatchBoxSize", false)) {
				foreach(const QString & Key, theConf->ListKeys("SizeCache")) {
					if (!AllBoxes.contains(Key.toLower()))
						theConf->DelValue("SizeCache/" + Key);
				}
			}
			else {
				theConf->DelValue("SizeCache");
			}

[DavidXanatos]

I'll go with

			foreach(const QString & Key, theConf->ListKeys("SizeCache")) {
				if (!AllBoxes.contains(Key.toLower()) || !theConf->GetBool("Options/WatchBoxSize", false))
					theConf->DelValue("SizeCache/" + Key);
			}