Fix SandMan Settings UI showing inverse of actual value for AutoRunSoftCompat #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks looks good |
offhub
added
User Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1678
I am still in the multi-hour QT install so didn't actually test but this is basic enough. in SandMan UI Settings the option variable was inverted for readability. For comparability it is still stored the same way.
Setting the value from the ui does this correctly:
theConf->SetValue("Options/AutoRunSoftCompat", !ui.chkNoCompat->isChecked());reading from the UI previously was not inverting the value:
ui.chkNoCompat->setChecked(theConf->GetBool("Options/AutoRunSoftCompat", true));