Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor classic installer fixes #1533

Merged
merged 3 commits into from
Jan 10, 2022
Merged

Minor classic installer fixes #1533

merged 3 commits into from
Jan 10, 2022

Conversation

sredna
Copy link
Contributor

@sredna sredna commented Jan 9, 2022

  • No need for System::Call when there is a constant for it.
  • Use InetC for downloads.
  • Don't use root of %temp% to avoid conflicts and DLL hell.

@sredna sredna marked this pull request as ready for review January 9, 2022 14:03
@isaak654 isaak654 added the Sbie Installer Sandboxie installer label Jan 9, 2022
@isaak654
Copy link
Collaborator

isaak654 commented Jan 9, 2022

About the DownloadInstallVCRedist part, I just verified that it doesn't check if the DLLs are present on the system32 folder.

Right now I'm on a clean W10 that doesn't contain by default those DLLs or the ones I used here, so this special case is not covered (according to my test) and the Sbie Installer won't tell you anything, but Classic still runs regardless of them.

So I would like to know your opinion about this behavior before merging these changes... do you think this could be kept in the current form or it would be better to always check latest VCRedist version?

Thank you for your contribution in this repository!

@sredna
Copy link
Contributor Author

sredna commented Jan 10, 2022

The "MS libraries are all static with Visual Studio 2015" comment implies that you don't need any of the C-runtime DLLs. If that is the case then all that stuff can remain unused.

@isaak654 isaak654 merged commit a030133 into sandboxie-plus:master Jan 10, 2022
@sredna sredna deleted the classicinst branch January 10, 2022 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sbie Installer Sandboxie installer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants