Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in RustNotify causing RuntimeError: Already borrowed on exit/signal #221

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Conversation

vrslev
Copy link
Contributor

@vrslev vrslev commented Mar 24, 2023

Done as suggested in PyO3/pyo3#2525 (comment)
Fixes #200

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #221 (f86439d) into main (afb8f34) will decrease coverage by 0.51%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #221      +/-   ##
===========================================
- Coverage   100.00%   99.49%   -0.51%     
===========================================
  Files            6        6              
  Lines          393      393              
  Branches        80       80              
===========================================
- Hits           393      391       -2     
- Misses           0        1       +1     
- Partials         0        1       +1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afb8f34...f86439d. Read the comment docs.

@samuelcolvin
Copy link
Owner

Looks good to me, have you tried this, does it solve the problem?

@vrslev
Copy link
Contributor Author

vrslev commented Mar 25, 2023

@samuelcolvin Yes 🤠
Previously in some scenarios cancelling execution with Ctrl+C it would end up throwing the RuntimeError, not it doesn’t.

@vrslev
Copy link
Contributor Author

vrslev commented Mar 25, 2023

Is decrease in coverage related to the actual code changes?

@samuelcolvin samuelcolvin merged commit 772a440 into samuelcolvin:main Mar 25, 2023
@samuelcolvin
Copy link
Owner

Thanks so much, I'll make a new release.

@vrslev vrslev deleted the vrslev/issue200 branch March 25, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in RustNotify causing RuntimeError: Already borrowed on exit/signal
2 participants