Switch flake8->ruff #212
Switch flake8->ruff #212
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 391 391
Branches 82 82
=========================================
Hits 391 391 Continue to review full report at Codecov.
|
requirements/linting.txt
Outdated
| sniffio==1.3.0 | ||
| # via trio | ||
| sortedcontainers==2.4.0 | ||
| # via trio | ||
| tomli==2.0.1 |
There was a problem hiding this comment.
Are you sure tomli should be removed here? Did you generate this with pip-compile?
There was a problem hiding this comment.
Did pip-compile requirements/linting.in -o requirements/linting.txt exactly
There was a problem hiding this comment.
Are you sure
tomlishould be removed here? Did you generate this with pip-compile?
Apologies, you were right indeed. I ran pip-compile on 3.11 initially.
Now ran the above command (pip-compile requirements/linting.in -o requirements/linting.txt) in 3.10 and tomli is indeed kept as is (which makes sense considering it was added from black/mypy). Fixed in latest commit, sorry about that
There was a problem hiding this comment.
No problem, easy mistake to make. Would be wonderful if pip-compile could know what versions are required.
|
Thanks so much. |
Hi @samuelcolvin ,
I noticed you moved from
flake8toruffonpydantic-core(pydantic/pydantic-core@bfe2d13), so I thought it would be a good idea too inwatchfiles.