This repository has been archived by the owner on Feb 15, 2023. It is now read-only.
Make pagination an option for FieldFunc #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1205
💛 - Coveralls |
berfarah
commented
Nov 15, 2018
| Name: name, | ||
| Fn: f, | ||
| }) | ||
| o.FieldFunc(name, f, Paginated) |
There was a problem hiding this comment.
This uses the new API under the hood now
| @@ -914,21 +912,22 @@ func (sb *schemaBuilder) buildStruct(typ reflect.Type) error { | |||
| for _, name := range names { | |||
| method := methods[name] | |||
|
|
|||
| if method.Paginated { | |||
There was a problem hiding this comment.
I'm fine with this having separate code paths for now
|
|
||
| // NonNullable is an option that can be passed to a FieldFunc to indicate that | ||
| // its return value is required, even if the return value is a pointer type. | ||
| func NonNullable(m *method) { | ||
| var NonNullable fieldFuncOptionFunc = func(m *method) { |
There was a problem hiding this comment.
This is a kinda cute pattern 😄
There was a problem hiding this comment.
maybe a quick example in the commit message for what the more complicated case will look like is useful.
willhug
approved these changes
Nov 15, 2018
| @@ -85,6 +90,9 @@ func (s *Object) Key(f string) { | |||
| type method struct { | |||
| MarkedNonNullable bool | |||
| Fn interface{} | |||
|
|
|||
| // Connection configuration | |||
There was a problem hiding this comment.
? Is this meant as a header for the section?
There was a problem hiding this comment.
Yeah - I can remove it for now if it's confusing
berfarah
force-pushed
the
bf/pagination
branch
from
ad3ee8b to
e51a366
Compare
This is in preparation for some more complex options we will be
introducing as part of our pagination work.
eg:
// thunder/graphql/...
type PaginationSort map[string]interface{}
// someone using thunder can pass in any option:
schema.FieldFunc(ctx, getPaginatedResource, Pagination)
schema.FieldFunc(ctx, getPaginatedResource, PaginationSort{
"groupName": func(ctx, resource) string {
return "theGroupName"
}
})
// and doesn't have to do this:
schema.FieldFunc(ctx, getPaginatedResource, PaginationSort{
...
}.Option)
berfarah
force-pushed
the
bf/pagination
branch
from
e51a366 to
5fbcc74
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't require PaginateFieldFunc for creating field funcs. Rather, FieldFunc takes in a Paginate option.