Skip to content
This repository has been archived by the owner on Feb 15, 2023. It is now read-only.

go sqlgen: add BuildStruct #195

Merged
merged 3 commits into from
Nov 9, 2018
Merged

go sqlgen: add BuildStruct #195

merged 3 commits into from
Nov 9, 2018

Conversation

changpingc
Copy link
Contributor

Add BuildStruct method back into sqlgen so we can parse
binlog row event the same way we scan from MySQL driver.

This was removed in #166.

changpingc added a commit that referenced this pull request Nov 8, 2018
@changpingc changpingc force-pushed the changping/build-struct branch from c3730db to ec4c471 Compare November 8, 2018 02:11
changpingc added a commit that referenced this pull request Nov 8, 2018
@coveralls
Copy link

coveralls commented Nov 8, 2018

Pull Request Test Coverage Report for Build 1187

  • 33 of 48 (68.75%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 65.762%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sqlgen/reflect.go 33 48 68.75%
Files with Coverage Reduction New Missed Lines %
graphql/schemabuilder/reflect.go 8 72.8%
Totals Coverage Status
Change from base Build 1179: -0.08%
Covered Lines: 3561
Relevant Lines: 5415

💛 - Coveralls

Make it defined on Schema instead of as a package-level function.
Add BuildStruct method back into sqlgen so we can parse
binlog row event the same way we scan from MySQL driver.

This was removed in #166.
@changpingc changpingc force-pushed the changping/build-struct branch from ec4c471 to 8f0e1ef Compare November 9, 2018 00:53
Copy link
Contributor

@berfarah berfarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 nit: maybe livesql should use these too

@changpingc changpingc merged commit 3edd36b into master Nov 9, 2018
@changpingc changpingc deleted the changping/build-struct branch November 9, 2018 01:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants