This repository has been archived by the owner on Feb 15, 2023. It is now read-only.
go fields: explicity support non-pointer marshalers #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1142
💛 - Coveralls |
berfarah
commented
Oct 9, 2018
| @@ -19,6 +19,18 @@ type Valuer struct { | |||
| value reflect.Value | |||
| } | |||
|
|
|||
| var marshalerType = reflect.TypeOf((*marshaler)(nil)).Elem() | |||
|
|
|||
| func nonPointerMarshal(d *Descriptor, val reflect.Value) (reflect.Value, bool) { | |||
There was a problem hiding this comment.
TODO: add a comment here explaining exactly what this is doing
There was a problem hiding this comment.
+1
Naming the return types might help too (especially the bool)
stephen
approved these changes
Oct 9, 2018
internal/fields/sql.go
Outdated
|
|
||
| func nonPointerMarshal(d *Descriptor, val reflect.Value) (reflect.Value, bool) { | ||
| if !d.Ptr && reflect.PtrTo(d.Type).Implements(marshalerType) { | ||
| fmt.Printf("typ: %+v, intf %v, intftyp: %T\n", d, val.Interface(), val.Interface()) |
| @@ -229,8 +229,7 @@ func TestField_ValidateSQLType(t *testing.T) { | |||
| {In: ifaceBinaryMarshal{}, Error: true}, | |||
| {In: ifaceBinaryMarshal{}, Tags: []string{"binary"}, Error: false}, | |||
| {In: &ifaceBinaryMarshal{}, Tags: []string{"binary"}, Error: false}, | |||
| // Non-pointer proto does not work because the Marshal() method has a pointer receiver. | |||
willhug
approved these changes
Oct 9, 2018
berfarah
force-pushed
the
bf/non-ptr-proto-support
branch
from
0ff8421 to
420cf3e
Compare
|
As noted in my second commit with the benchmark, we see an increase of 1 allocation on the write path here (5 vs the typical 4). We're explicitly ok with this cost, given that:
|
What we see here is an additional allocation for the non-ptr proto to the heap. We expect this, since we have to create a new pointer in order to satisfy the marshaler interface. We deem this cost worth the additional safety of not having to deal with pointers. Since people have to opt-in to use this feature there isn't a noticeable difference to existing code-paths.
berfarah
force-pushed
the
bf/non-ptr-proto-support
branch
from
420cf3e to
25dfb08
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we sometimes might want to use non-pointers for protobuf, check our non-pointer types.
Test plan: