Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Request: Set hash route in manifest entry file. #90

Closed
imrockpan opened this issue Apr 10, 2023 · 2 comments · Fixed by #92
Closed

Feat Request: Set hash route in manifest entry file. #90

imrockpan opened this issue Apr 10, 2023 · 2 comments · Fixed by #92
Labels
enhancement New feature or request

Comments

@imrockpan
Copy link

I really hope that hash route can be set in the manifest entry file.
It is very useful in the following usage scenarios:

{
  // ...
  "action": {
    "default_popup": "src/app.html#/popup/dashboard"
  },
  "options_page": "src/app.html#/options",
  // ...
}

Multiple pages are in App, it can reduce my template code.

@samrum
Copy link
Owner

samrum commented Apr 11, 2023

It seems like Chrome supports hashes and even query parameters in manifest.json, so it should be possible.

Would need to update the input/output parsing of manifest HTML files so they're maintained on builds.

@imrockpan
Copy link
Author

It seems like Chrome supports hashes and even query parameters in manifest.json, so it should be possible.

Would need to update the input/output parsing of manifest HTML files so they're maintained on builds.

That's great, thanks for responding so quickly. 🙏
Super awesome plugin, saved me a lot of time. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants