Skip to content

Commit

Permalink
fix: use_dynamic_url with content scripts does not work in Chrome 130
Browse files Browse the repository at this point in the history
Not really a fix, but changed the default value of
useDynamicUrlWebAccessibleResources to false and added a note to the
README with a link to related Chromium issue

https://issues.chromium.org/issues/363027634
  • Loading branch information
samrum committed Sep 23, 2024
1 parent 1e6b679 commit 50fbe9e
Show file tree
Hide file tree
Showing 25 changed files with 3,017 additions and 2,206 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
uses: actions/checkout@v3

- name: Install pnpm
uses: pnpm/action-setup@v2.2.4
uses: pnpm/action-setup@v4.0.0

- name: Setup node
uses: actions/setup-node@v3
uses: actions/setup-node@v4.0.4
with:
node-version: 18.x
registry-url: https://registry.npmjs.org/
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
uses: actions/checkout@v3

- name: Install pnpm
uses: pnpm/action-setup@v2.2.4
uses: pnpm/action-setup@v4.0.0

- name: Setup node
uses: actions/setup-node@v3
uses: actions/setup-node@v4.0.4
with:
node-version: 18.x
registry-url: https://registry.npmjs.org/
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,9 @@ manifest
useDynamicUrlWebAccessibleResources (optional)

- Type: `boolean`
- Default: `true`
- Default: `false`
- Adds the `use_dynamic_url` property to web accessible resources generated by the plugin
- Caution: In Chrome 130, with this option enabled, importing a generated resource using `chrome.runtime.getURL` will not work ([Chromium Issue](https://issues.chromium.org/issues/363027634))l

optimizeWebAccessibleResources (optional)

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"standard-version": "^9.5.0",
"typescript": "^5.3.3",
"unbuild": "^2.0.0",
"vitest": "^1.0.4"
"vitest": "^2.1.1"
},
"peerDependencies": {
"vite": "^4.0.3 || ^5.0.0"
Expand Down
Loading

0 comments on commit 50fbe9e

Please sign in to comment.