Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): update additional info #1237

Merged
merged 4 commits into from
Aug 22, 2024
Merged

feat(docs): update additional info #1237

merged 4 commits into from
Aug 22, 2024

Conversation

ryoppippi
Copy link
Contributor

@ryoppippi ryoppippi commented Aug 22, 2024

Fixed some statements on setup

  • additional bundling is a vague statement, so I added concrete bundler names there.
  • fix link of unplugin-typia's examples
  • add a small description about how vite plugins works

@ryoppippi
Copy link
Contributor Author

ryoppippi commented Aug 22, 2024

I'm waiting for my friends review. When it is done, remove draft

Updated the setup documentation to recommend using `unplugin-typia` for
additional bundling when using `Typia` with bundlers like `vite`, `rollup`,
and `webpack`.
Updated the link to the examples projects in the unplugin-typia repository
to point to the correct path under the main branch.
Added an informational callout in the setup documentation for Vite,
highlighting the compatibility of `unplugin-typia` with other plugins
like `@vitejs/plugin-react-swc`. This clarifies that `unplugin-typia`
processes TypeScript code before transforming it to JavaScript,
ensuring compatibility with any plugins.
@ryoppippi ryoppippi marked this pull request as ready for review August 22, 2024 11:07
@ryoppippi
Copy link
Contributor Author

plz review it!

Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating.

@samchon samchon merged commit 77bff43 into samchon:master Aug 22, 2024
2 checks passed
@ryoppippi ryoppippi deleted the docs branch August 22, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants