Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suse): skip directory management #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tacerus
Copy link
Contributor

@tacerus tacerus commented Mar 14, 2024

On SUSE based distributions the chroot/data directory is managed by the distribution package. Skip superfluous management and permission overwriting through the formula states.

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Add "manage_directories" conditional, enable it by default and disable it on SUSE based distributions.

Pillar / config required to test the proposed changes

n/a

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

On SUSE based distributions the chroot/data directory is managed
by the distribution package. Skip superfluous management and
permission overwriting through the formula states.

Signed-off-by: Georg Pfuetzenreuter <[email protected]>
@tacerus tacerus requested a review from daks as a code owner March 14, 2024 01:43
@daks daks requested a review from a team March 14, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant