-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @lwc/lwc/valid-api eslint for data #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, tests are failing. 🫠
Co-authored-by: Will Harney <[email protected]>
Co-authored-by: Eugene Kashida <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, pending an update to the existing error message.
What is the context for this change? Is there a Work Item or Slack thread? |
Co-authored-by: Will Harney <[email protected]>
This PR updates the restriction on
data
to not includedata
itself since this is a valid api name. It also addsdataset
to the list of reserved apis.