Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @lwc/lwc/valid-api eslint for data #161

Merged
merged 12 commits into from
Jul 25, 2024
Merged

Conversation

Templarian
Copy link
Contributor

This PR updates the restriction on data to not include data itself since this is a valid api name. It also adds dataset to the list of reserved apis.

Copy link
Contributor

@wjhsf wjhsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, tests are failing. 🫠

lib/rules/valid-api.js Outdated Show resolved Hide resolved
lib/rules/valid-api.js Outdated Show resolved Hide resolved
lib/rules/valid-api.js Outdated Show resolved Hide resolved
lib/rules/valid-api.js Outdated Show resolved Hide resolved
lib/rules/valid-api.js Outdated Show resolved Hide resolved
Co-authored-by: Eugene Kashida <[email protected]>
lib/rules/valid-api.js Outdated Show resolved Hide resolved
Copy link
Member

@ekashida ekashida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending an update to the existing error message.

lib/rules/valid-api.js Outdated Show resolved Hide resolved
@nolanlawson
Copy link
Contributor

What is the context for this change? Is there a Work Item or Slack thread?

@wjhsf wjhsf merged commit 34911de into salesforce:master Jul 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants