Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lwc/consistent-component-name support for .ts files #110

Merged

Conversation

twoplustwoone
Copy link
Contributor

The lwc/consistent-component-name rule fails for .ts files as described in #109 . This PR aims to solve it by agnostically removing the extension from the file being checked, thus including .js and .ts files. This also opens up to other file extensions, but from what I gather, that shouldn't cause problems.

@twoplustwoone twoplustwoone changed the title Add consistent-component-name support for .ts files Add lwc/consistent-component-name support for .ts files Dec 30, 2022
Copy link
Member

@pmdartus pmdartus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for the PR @twoplustwoone.

@pmdartus pmdartus merged commit efb4490 into salesforce:master Jan 2, 2023
@twoplustwoone twoplustwoone deleted the feat/consistent-component-name-ts branch January 2, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants