Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Fix copy tests #2996

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Tests: Fix copy tests #2996

merged 1 commit into from
Dec 11, 2023

Conversation

mike10ca
Copy link
Contributor

What it solves

Resolves #

How this PR fixes it

  • Quick fix for data copy tests to clipboard

Copy link

github-actions bot commented Dec 11, 2023

Branch preview

✅ Deploy successful!

https://fix_copy_tests--walletweb.review-wallet-web.5afe.dev

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.53 MB (🟡 +136.71 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirty-nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 565 B (🟡 +3 B) 1.53 MB
/404 705 B (🟡 +3 B) 1.53 MB
/_error 229 B (🟢 -2 B) 1.53 MB
/_offline 1.09 KB (🟡 +8 B) 1.53 MB
/addOwner 3.52 KB (🟢 -78 B) 1.53 MB
/address-book 26.2 KB (🟡 +637 B) 1.56 MB
/apps 34.81 KB (🟡 +218 B) 1.56 MB
/apps/bookmarked 447 B (🟡 +3 B) 1.53 MB
/apps/custom 27.31 KB (🟡 +186 B) 1.56 MB
/apps/open 26.74 KB (🟢 -18 B) 1.56 MB
/balances 26.63 KB (🟡 +112 B) 1.56 MB
/balances/nfts 18.66 KB (🟢 -22 B) 1.55 MB
/cookie 8.85 KB (🟢 -25 B) 1.54 MB
/home 60.6 KB (🔴 +36.99 KB) 1.59 MB
/imprint 1.4 KB (🟢 -9 B) 1.53 MB
/licenses 5.13 KB (🟢 -3 B) 1.53 MB
/new-safe/create 11.92 KB (🟡 +94 B) 1.54 MB
/new-safe/load 7.32 KB (🟡 +31 B) 1.54 MB
/privacy 15.88 KB (🟡 +6 B) 1.54 MB
/settings 450 B (🟡 +1 B) 1.53 MB
/settings/appearance 8.04 KB (🟢 -494 B) 1.54 MB
/settings/cookies 7.61 KB (🟢 -159 B) 1.54 MB
/settings/data 7.51 KB (🟢 -158 B) 1.54 MB
/settings/environment-variables 8.83 KB (🟢 -139 B) 1.54 MB
/settings/modules 12.63 KB (🔴 +2.73 KB) 1.54 MB
/settings/notifications 11.18 KB (🟢 -94 B) 1.54 MB
/settings/safe-apps 12.14 KB (🟢 -133 B) 1.54 MB
/settings/security-login 46.36 KB (🔴 +31.99 KB) 1.57 MB
/settings/setup 36.03 KB (🔴 +11.73 KB) 1.56 MB
/share/safe-app 9.37 KB (🟢 -76 B) 1.54 MB
/terms 9.99 KB (🟢 -76 B) 1.54 MB
/transactions 52.52 KB (🟡 +52 B) 1.58 MB
/transactions/history 52.49 KB (🟡 +53 B) 1.58 MB
/transactions/messages 18.56 KB (🟢 -32 B) 1.55 MB
/transactions/queue 26.6 KB (🔴 +7.46 KB) 1.56 MB
/transactions/tx 6.15 KB (🟢 -110 B) 1.54 MB
/wc 570 B (🟡 +2 B) 1.53 MB
/welcome 7.09 KB (🟢 -39 B) 1.54 MB
/welcome/social-login 7.55 KB (🟢 -19 B) 1.54 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 76.77% 10989/14314
🔴 Branches 51.86% 2269/4375
🟡 Functions 60.4% 1673/2770
🟡 Lines 78.14% 9941/12722

Test suite run success

1288 tests passing in 178 suites.

Report generated by 🧪jest coverage report action from 0387e65

@mike10ca mike10ca marked this pull request as ready for review December 11, 2023 12:17
@francovenica francovenica self-requested a review December 11, 2023 12:35
@mike10ca mike10ca merged commit 839fd3e into dev Dec 11, 2023
15 checks passed
@mike10ca mike10ca deleted the fix-copy-tests branch December 11, 2023 15:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants