Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Display network logos in network selector #2992

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Dec 11, 2023

What it solves

  • Shows network logos for the network selector
  • Splits up the network selector into testnets and non-testnets
  • Shows network logos for the chain indicator except in the sidebar and safe list sidebar

How to test it

  1. Open Safe and observe network logos in the network selector
  2. Open the sidebar and observe no network logo there
  3. Open the safe list sidebar and observe no network logo there

Screenshots

Screenshot 2023-12-11 at 12 10 29 Screenshot 2023-12-11 at 15 34 11 Screenshot 2023-12-11 at 15 34 23 Screenshot 2023-12-11 at 15 34 40 Screenshot 2023-12-11 at 15 34 58

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Dec 11, 2023

Branch preview

✅ Deploy successful!

https://network_selector--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Dec 11, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Dec 11, 2023

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.53 MB (🟡 +484 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps 34.81 KB (🟡 +2 B) 1.56 MB
/apps/custom 27.31 KB (🟡 +2 B) 1.56 MB
/home 60.6 KB (🟡 +2 B) 1.59 MB
/share/safe-app 9.37 KB (🟡 +1 B) 1.54 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Dec 11, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
77.67% (+0.01% 🔼)
11139/14341
🔴 Branches
53.82% (+0.02% 🔼)
2361/4387
🟡 Functions
61.34% (+0.01% 🔼)
1706/2781
🟡 Lines
78.99% (+0.01% 🔼)
10064/12741
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
100%
76.19% (-3.81% 🔻)
100% 100%

Test suite run success

1321 tests passing in 181 suites.

Report generated by 🧪jest coverage report action from 5491a81

@katspaugh
Copy link
Member

@TanyaEfremova @liliiaorlenko should we add a rounded border around each chain or something like that on these screen?

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

github-actions bot commented Dec 11, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

LGTM

I think I looked everywhere where the logo might be (like the top right corner of a form like send funds) but I didn't find anything broken or a missing logo.
Checked the network selector and apps
Checked in mobile viewport as well
Checked that there are no logos in the sidebar

@usame-algan usame-algan merged commit 5c8e3dc into dev Dec 12, 2023
15 checks passed
@usame-algan usame-algan deleted the network-selector branch December 12, 2023 06:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants