Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename alphanumeric function #949

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

PaulRBerg
Copy link
Member

Copy link
Member

@smol-ninja smol-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@andreivladbrg andreivladbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good feedback left on solady, isAlphanumericWithSpaces is more precise

LGTM

@PaulRBerg
Copy link
Member Author

great thanks guys, I'm squashing and merging

@PaulRBerg PaulRBerg merged commit 94373ae into staging Jun 19, 2024
9 checks passed
@PaulRBerg PaulRBerg deleted the refactor/rename-alphanumeric-function branch June 19, 2024 10:32
andreivladbrg added a commit that referenced this pull request Jul 3, 2024
* refactor: rename alphanumeric function

* chore: update precompiles

---------

Co-authored-by: andreivladbrg <[email protected]>
andreivladbrg added a commit that referenced this pull request Jul 3, 2024
* refactor: rename alphanumeric function

* chore: update precompiles

---------

Co-authored-by: andreivladbrg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants