LockupTranched contract #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreivladbrg
force-pushed
the
feat/lockup-tranched
branch
from
aa9246f to
ed84a49
Compare
andreivladbrg
force-pushed
the
staging
branch
from
7f0a642 to
9f857d0
Compare
andreivladbrg
force-pushed
the
feat/lockup-tranched
branch
4 times, most recently
from
c9374a1 to
2a97859
Compare
andreivladbrg
force-pushed
the
staging
branch
from
47d702a to
3f36df4
Compare
andreivladbrg
force-pushed
the
feat/lockup-tranched
branch
from
ed72561 to
41ad50a
Compare
andreivladbrg
commented
Feb 16, 2024
andreivladbrg
force-pushed
the
staging
branch
from
c47eebd to
e4583dc
Compare
andreivladbrg
force-pushed
the
feat/lockup-tranched
branch
from
a03c2d2 to
c353ea1
Compare
|
What should be the symbol of
@PaulRBerg @smol-ninja do you have other suggestions? |
|
Wouldn't changing it to anything else other than I prefer |
|
smol-ninja
requested changes
Feb 24, 2024
test/integration/concrete/lockup-tranched/token-uri/tokenURI.t.sol
Outdated
Show resolved
Hide resolved
test/integration/concrete/lockup-tranched/token-uri/tokenURI.t.sol
Outdated
Show resolved
Hide resolved
smol-ninja
requested changes
Mar 4, 2024
smol-ninja
reviewed
Mar 4, 2024
|
@smol-ninja, i've addressed your feedback. lmk if there is anything left, otherwise can you approve? planning to resolve the conflicts and merge tomorrow |
smol-ninja
approved these changes
Mar 6, 2024
andreivladbrg
force-pushed
the
feat/lockup-tranched
branch
2 times, most recently
from
261d8dc to
7a1abfa
Compare
feat: include tranched in mapSymbol in NFTDescriptor docs: specify LockupTranched in README build: add SablierV2LockupTranched in shell scripts test: test SablierV2LockupTranched contract test: deploy core contracts in Base_Test test: use changePrank instead of vm.StartPrank test: update Precompiles bytecode
andreivladbrg
force-pushed
the
feat/lockup-tranched
branch
from
7a1abfa to
5ebdb03
Compare
|
@smol-ninja i have realized that i have not included can you confirm that it looks good again? sorry |
|
Looks good. |
PaulRBerg
reviewed
Apr 8, 2024
PaulRBerg
reviewed
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #787
About
It introduces the
SablierV2LockupTranchedcontract, similar to the Dynamic contract. However, it differentiates itself by storing tranches instead of segments. TheTranchedata structure mirrors theSegment, having the same variables , excluding the exponent.The calculation of the streamed amount is basically the sum of all vested
tranche.amounts.Other changes
ISablierV2LockupDynamicBase_Testcontract to approve each core contract when a user is created.