Add support for zhimi.humidifier.ca4 (miot) #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toxblh
changed the title
…g percentage of the level
…ssistant and other modules
|
@rytilahti Hi, could you help me here, what is wrong with "Labeler / label" check? |
|
Hey, first of all, thanks for the PR! I will do a code review soon. Wrt the labeler (which simply adds labels to PRs), looks like it works on repositories it has write access (https://github.community/t/github-actions-are-severely-limited-on-prs/18179), rendering it pretty much useless for this project. I'm going to disable it for the time being, so no need to worry about that. I'll do a code review soon |
rytilahti
requested changes
Jul 27, 2020
Co-authored-by: Teemu R. <[email protected]>
Co-authored-by: Teemu R. <[email protected]>
Toxblh
commented
Jul 27, 2020
…ties. Added Logger for catch branch. Updated tests
rytilahti
changed the title
21 tasks
xvlady
pushed a commit
to xvlady/python-miio
that referenced
this pull request
May 9, 2021
* Added minimal functionality for work air humidifier via miot for zhimi.humidifier.ca4 * Implemented all features of air humidifier miot * Added tests for air humidifier miot * Airhumidifier_miot added divided by 1.25 for water level for providing percentage of the level * airhumidifier miot added and updated tests * Added miio.airhumidifier_miot to docs * AirHumidifier_Miot. Changed to consistent naming of methods for homeAssistant and other modules * miio/airhumidifier_miot.py Remove the duplicate docstring. Co-authored-by: Teemu R. <[email protected]> * Update miio/airhumidifier_miot.py Co-authored-by: Teemu R. <[email protected]> * Added Xiaomi Mi Air Humidifier CA4 to Readme * AirHumidifierMiot. State fault -> error. Consistent in desc of properties. Added Logger for catch branch. Updated tests Co-authored-by: Teemu R. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added minimal functionality for work with zhimi.humidifier.ca4 and similar in future humidifiers.
Close one of device from the #627 issue