Fix support for ignored directories #369
Conversation
| @@ -33,7 +33,7 @@ | |||
| "start_win": "set DEBUG=raneto&&node example/server.js", | |||
| "test": "npm run lint && mocha --reporter spec test/*.js", | |||
| "gulp": "gulp", | |||
| "lint": "./node_modules/.bin/eslint bin/* app/**/*.js example/**/*.js test/*.js gulpfile.js", | |||
| "lint": "eslint bin/* app/**/*.js example/**/*.js test/*.js gulpfile.js", | |||
There was a problem hiding this comment.
Reason for this? not everyone has eslint installed globally.
Will NPM handle this in such a case?
There was a problem hiding this comment.
Hey @ryanlelek , yes in my experience npm handles it nicely and I always use commands like this.
If I don't I get this error in Windows + git bash:
There was a problem hiding this comment.
Having some kind of dejavu: gilbitron/Raneto-Core#15 (comment) :D
Just wanted to clarify that it wouldn't try a global installation, what npm does is to prepend all bin commands in your PATH before running the script, which means that local eslint will be picked up.
There was a problem hiding this comment.
Hi @ryanlelek, I can undo this change if you prefer. However I think this is the right way to set it up, it always worked like a charm for me in cross platform setups.
There was a problem hiding this comment.
It makes sense, thank you for the clarification.
In npm world, it adds its .bin/ to the search path. This may not(?) have always been the case which might be why I got in the habit.
ryanlelek
added
pending
|
Merging, thank you! |
There was old support for ignoring directories in listing: gilbitron/Raneto-Core@d74a0e1
but it was crashing when attempting to use it.
This PR adds it to test content and fixes the crash.