-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error redirect not logged in anymore #340
Comments
Yep, sounds reasonable! |
ryanlelek
added a commit
that referenced
this issue
May 10, 2021
Ok, added this functionality. Thank you! |
AnkushLambdatest
pushed a commit
to AnkushLambdatest/Raneto
that referenced
this issue
Jun 29, 2022
AnkushLambdatest
pushed a commit
to AnkushLambdatest/Raneto
that referenced
this issue
Jun 29, 2022
Edit: Adding suggestion in ryanlelek#340
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey I have found a error if you are logged in to the page and the webserver restarts and you want to refresh the edit page, the redirect is not relative to base url.
It is found in the wildcard.route.js line 66
// Edit Page if ((config.authentication || config.authentication_for_edit) && !req.session.loggedIn) { res.redirect('/login'); return; }
It should be like this yes?
res.redirect(config.base_url + '/login');
This is important only where the app has a not default base_url. For example the app can be found for /mywiki.
In this case instead of /mywiki/login it will only redirect to /login where no route can be found.
Sorry if this is not an error and should be like this.
The text was updated successfully, but these errors were encountered: